Skip to content

Conversation

Vr93
Copy link
Collaborator

@Vr93 Vr93 commented Apr 2, 2020

No description provided.

Copy link
Owner

@ks93 ks93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need doc-strings :)

import time
from xlogger.logger import logger

def log(**kwargs):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs doc-string

@@ -0,0 +1,43 @@
import functools
import time
from xlogger.logger import logger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work with the cross-file logging ideology? Will this work with the same logger instance?

return wrapper_log
return decorator_log

def _convert_str_to_int_log_level(log_level):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use an enum for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants