Skip to content

Commit

Permalink
cleanup, remove old/unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
Dan Delany committed Dec 18, 2017
1 parent 6c3f513 commit a43007a
Show file tree
Hide file tree
Showing 8 changed files with 210 additions and 272 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Charting library for React
* *planned: AreaRect?, AreaCircle?*

### Higher-order components
* resolveObjectProps
* resolveXYScales

### Utilities
Expand Down
2 changes: 1 addition & 1 deletion docs/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Playground from './Playground';
const lessons = [
{name: "Quick Start", path: '/quick-start', Component: Lessons.QuickStartLesson},
{name: "XY Plots", path: '/xy-plots', Component: Lessons.XYPlotsLesson},
{name: "Getters & Accessors", path: '/getters-and-accessors', Component: Lessons.GettersAndAccessorsLesson},
// {name: "Getters & Accessors", path: '/getters-and-accessors', Component: Lessons.GettersAndAccessorsLesson},
// {name: "Interaction", path: '/interaction', Component: Lessons.InteractionLesson},
];

Expand Down
2 changes: 1 addition & 1 deletion src/BarChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function makeRangeBarChartProps(barChartProps) {
* where each bar represents a single independent variable value and a single dependent value,
* with bars that are centered horizontally on x-value and extend from 0 to y-value,
* (or centered vertically on their y-value and extend from 0 to the x-value, in the case of horizontal chart variant)
* eg. http://www.snapsurveys.com/wp-content/uploads/2012/10/bar_2d8.png
* eg. http://www.snapsu rveys.com/wp-content/uploads/2012/10/bar_2d8.png
*
* For other bar chart types, see RangeBarChart and AreaBarChart
*/
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ export {default as YAxisTitle} from './YAxisTitle';
export {default as YGrid} from './YGrid';
export {default as YTicks} from './YTicks';

// ### Higher-order components
export {default as resolveObjectProps} from './utils/resolveObjectProps';
// Higher-order components
export {default as resolveXYScales} from './utils/resolveXYScales';

// Containers
export {default as ZoomContainer} from './ZoomContainer';

import * as Data from './utils/Data';
Expand Down
2 changes: 1 addition & 1 deletion src/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function hasOneOfTwo(a, b) {
}

function componentName(Component) {
return Component.displayName || "Component wrapped by resolveObjectProps";
return Component.displayName || "Component";
}

function hasSome(obj, keys) {
Expand Down
1 change: 0 additions & 1 deletion tests/jsdom/spec/BarChart.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ describe('BarChart', () => {

([0, 1, 2]).forEach((i) => {
const barProps = bars.at(i).props();
console.log(_.pick(barProps, ['x','y','width','height']));
expect(barProps.x).to.equal(xScale(xTestValues[i]) - (props.barThickness / 2));
expect(barProps.width).to.equal(props.barThickness);
const yZero = yScale(0);
Expand Down
134 changes: 0 additions & 134 deletions tests/jsdom/spec/resolveObjectProps.spec.js

This file was deleted.

Loading

0 comments on commit a43007a

Please sign in to comment.