Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: never use a transition on the shell route #1653

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: never use a transition on the shell route #1653

merged 1 commit into from
Feb 25, 2025
+16 −6

Conversation

evoL
Copy link
Contributor

@evoL evoL commented Feb 24, 2025 •
edited
Loading

Changing the PageBuilder here based on a MediaQuery causes the child to briefly be rendered twice with the same GlobalKey, blowing up the rendering.

I believe this fixes #1534.

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

@evoL
fix: never use a transition on the shell route
7b3c1ad 
Changing the PageBuilder here based on a MediaQuery causes the child to briefly
be rendered twice with the same GlobalKey, blowing up the rendering.

I believe this fixes krille-chan#1534.
@evoL evoL marked this pull request as ready for review February 24, 2025 22:03
@evoL evoL requested a review from krille-chan as a code owner February 24, 2025 22:03
@krille-chan
Copy link
Owner

Whoa this is great! Thank you so much

krille-chan
krille-chan approved these changes Feb 25, 2025
View reviewed changes
Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it seems to work. I no longer see a crash when switching to/from column mode

@krille-chan krille-chan merged commit 9e7d939 into krille-chan:main Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krille-chan krille-chan krille-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while switching from landscape to portrait
2 participants
@evoL @krille-chan