Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prepare-web build script #1618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isosphere
Copy link

@isosphere isosphere commented Feb 15, 2025

remove quotes from version, but also handle absent directories.

remove directory traversal, use cli options

credit is due to @nebulade for #1129; I did not check for their PR before making this, but I did take their use of a command line arg to strip out the quotations. I was using sed, but this is better.

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed

N/A:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

remove quotes from version, but also handle absent directories.
remove directory traversal, use cli options
@isosphere
Copy link
Author

re: CI failure:

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant