fix: use relativeFundingRate for paper trading funding calculation#27
Closed
Ashok93 wants to merge 1 commit into
Closed
fix: use relativeFundingRate for paper trading funding calculation#27Ashok93 wants to merge 1 commit into
Ashok93 wants to merge 1 commit into
Conversation
The historical-funding-rates API returns two fields: - fundingRate: absolute/annualized rate - relativeFundingRate: actual per-interval rate Paper trading was using fundingRate, which overcharges by ~7000x. A $363 XAUTUSD position was charged $40.91 per interval instead of the correct $0.006.
agent-smith-k
added a commit
that referenced
this pull request
Apr 14, 2026
Paper trading was using the absolute/annualized fundingRate field from the historical-funding-rates API instead of relativeFundingRate (the actual per-interval rate), overcharging ~7000x per funding interval. Adds wiremock regression test to prevent field selection from regressing. Signed squash of #27 by @Ashok93 to satisfy branch protection signature requirements. Closes #26 Co-authored-by: Ashok <ashok.kannan93@gmail.com>
Contributor
agent-smith-k
added a commit
that referenced
this pull request
Apr 14, 2026
Paper trading was using the absolute/annualized fundingRate field from the historical-funding-rates API instead of relativeFundingRate (the actual per-interval rate), overcharging ~7000x per funding interval. Adds wiremock regression test to prevent field selection from regressing. Signed squash of #27 by @Ashok93 to satisfy branch protection signature requirements. Closes #26 Co-authored-by: Ashok <ashok.kannan93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The historical-funding-rates API returns two fields:
Paper trading was using fundingRate, which overcharges by ~7000x.