feat: add optional slippage simulation for paper market orders#24
Merged
Conversation
Add configurable slippage rate to paper trading market orders. Market buys fill at ask * (1 + slippage_rate), sells at bid * (1 - slippage_rate). Limit orders are unaffected. Default 0.0 preserves backward compatibility. Introduces PaperConfig struct to replace positional parameter bag. Adds --slippage-rate flag (with --slippage alias) to paper init and reset. Surfaces fee and slippage rates in paper status output. Closes #15 Co-authored-by: MacBobby Chibuzor <theghostmac@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--slippage-rate(alias--slippage) flag topaper initandpaper resetask * (1 + slippage_rate), sells atbid * (1 - slippage_rate)0.0preserves full backward compatibilityPaperConfigstruct replacing positional parameter bagpaper statusoutput (table and JSON)Signed squash of #20 by @theghostmac to satisfy branch protection signature requirements.
Closes #15
Made with Cursor