sync: Add contribution guidelines and fix config file permissions#22
Merged
Conversation
Replace write-then-chmod with atomic write: create a temp file with mode 0600 from the start via OpenOptionsExt, write content, fsync, then rename into place. Eliminates the window where credentials could be read by other local users between file creation and permission restriction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs two changes from upstream:
CONTRIBUTING.mdwith instructions for submitting PRs, reporting bugs, and requesting features. Links it from the README table of contents.Changes
CONTRIBUTING.mdwith PR guidelines, code style, and security disclosure referenceREADME.mdupdated with Contributing section and TOC linksrc/config.rs:save()now usesatomic_write_restrictedinstead offs::write+set_permissions_0600src/telemetry.rs:write_instance_id()uses the same atomic write patternMade with Cursor