Merged
Conversation
- CLITestHelper: Wrapper for Typer CliRunner with convenient methods - run(), run_with_temp_files(), mock_graph_load() - assert_success(), assert_failure() helpers - MockConfig: Simple mock config objects for testing - create_mock_client(): Factory for mock API clients - typer is optional dependency (dev-only) - Graceful ImportError if typer not available - Add 17 comprehensive tests - All 81 tests passing - Mypy clean Reduces CLI test boilerplate by ~40 lines per integration
- Fixed test_run_with_args to use --name option - Simplified temp file test (dir cleaned up after context) - All 79 tests passing
- Changed run_with_temp_files to not use context manager - Caller responsible for cleanup (more flexible) - Updated test to manually cleanup with shutil.rmtree - All 79 tests passing
Added comprehensive test suites for previously untested modules: **Config Module** (12 tests): - AuthConfig and IntegrationConfig models - Environment variable substitution - Config file loading with YAML **Registry Module** (4 tests): - Integration registration decorator - Get/list integrations - Clear registry **Utils Module** (13 tests): - FieldMapper: field mapping and nested extraction - IDCache: caching and fetch-or-get - BatchProcessor: batching and rate limiting - CommentBuilder: template building Total: +29 tests, 108 tests passing Coverage improvement: 75% → 92% (+17%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.