Merged
Conversation
- Add TierUtils class for tier validation and mapping - get_name(), validate_tier(), map_tier() methods - TIER_NAMES constant (1-5 mapping) - Reduces ~20 lines per integration - Add testing fixtures for easier test development - GraphFixture: simple_graph(), with_dependencies(), invalid_graph() - ManifestFixture: minimal(), full_featured(), with_tier() - Reduces ~30 lines of boilerplate per integration test - Add comprehensive test suites (20 new tests) - Update SDK exports for new modules - All 63 tests passing Phase 3 complete - DX improvements delivered
ryanm101
force-pushed
the
feat/tiermapping
branch
from
5d97322 to
3789876
Compare
- Field uses alias='x-security' so must use model_validate() with dict - Simplified fixtures removing invalid 'topics' field from Capability - All tests passing, mypy clean
x-security field is optional (has default None) but mypy incorrectly flags it as required due to Field alias configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits:
Standardized tier handling
Prevents invalid tier values in integrations
Reusable mapping logic
Note: Keep vendor-specific value mapping (e.g., "1 - Critical") in integration code