Repository navigation
Adding phased property to HaplotypeMatrix - #355
Open
mufernando wants to merge 1 commit into
Open
mufernando wants to merge 1 commit into
mufernando wants to merge 1 commit into
Conversation
Collaborator
|
One semantics question: do you prefer |
Member
Author
|
I prefer the empty methods you suggested. Will re-work that and then we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of my efforts to address #168.
Here, I included a
phasedproperty toHaplotypeMatrix, changed the docs to document the change, and changed all the down-stream methods that use this data structure to accommodate the new flag.I will add the warning functionality in a subsequent PR. The idea is to emit warnings when a
phased=FalseHaplotypeMatrixis used with statistics that depend on phased haplotypes.I had help from Claude Opus 5.5 and Opus 4.6.