Skip to content

IssuesProcessor cosmetics #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IssuesProcessor cosmetics #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions issues-processor/src/main/java/com/koval/resolver/processor/issues/IssuesProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.koval.resolver.processor.issues;

import static java.util.Collections.reverseOrder;
import static java.util.Comparator.comparingInt;

import java.io.File;
import java.io.IOException;
import java.util.*;
Expand Down Expand Up @@ -71,12 +74,7 @@ public void run(final Issue issue, final IssueAnalysingResult result) {
}

private <E> void addEntityOrUpdateMetric(final Map<E, Integer> map, final E entity) {
if (map.containsKey(entity)) {
final Integer oldMetricNumber = map.get(entity);
map.replace(entity, oldMetricNumber + 1);
} else {
map.put(entity, 1);
}
map.merge(entity, 1, Integer::sum);
}

private <E> List<Pair<E, Integer>> convertMapToPairList(final Map<E, Integer> map) {
Expand All @@ -102,17 +100,9 @@ private List<AttachmentResult> getAttachmentMetrics(
return attachmentResults;
}

public List<Pair<User, Integer>> sortUsersByRank(List<Pair<User, Integer>> listQualifiedUsers) {
listQualifiedUsers.sort((u1, u2) -> {
if (u1.getMetric().equals(u2.getMetric())) {
return 0;
} else if (u1.getMetric() < u2.getMetric()) {
return 1;
} else {
return -1;
}
});
return listQualifiedUsers;
}
public List<Pair<User, Integer>> sortUsersByRank(List<Pair<User, Integer>> listQualifiedUsers) {
listQualifiedUsers.sort(reverseOrder(comparingInt(Pair::getMetric)));

return listQualifiedUsers;
}
}