Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unallocated resource into mid resource #1750

Closed

Conversation

j4ckstraw
Copy link
Contributor

@j4ckstraw j4ckstraw commented Nov 22, 2023

implement mid-tier overcommitment in https://koordinator.sh/docs/designs/node-prediction/#mid-tier-overcommitment

Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid] Unallocated[Mid] = max(NodeAllocatable - Allocated[Prod], 0)

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@j4ckstraw j4ckstraw changed the title feat: add unallocated resource into mid resource [WIP] feat: add unallocated resource into mid resource Nov 22, 2023
@j4ckstraw j4ckstraw force-pushed the add-unallocated-into-mid-tier branch 3 times, most recently from 8631493 to 855492b Compare November 22, 2023 09:41
@j4ckstraw j4ckstraw changed the title [WIP] feat: add unallocated resource into mid resource feat: add unallocated resource into mid resource Nov 22, 2023
@j4ckstraw j4ckstraw force-pushed the add-unallocated-into-mid-tier branch from 855492b to fdb810a Compare November 22, 2023 10:08
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.16%. Comparing base (3784df1) to head (ff65d69).
Report is 231 commits behind head on main.

Files Patch % Lines
...troller/noderesource/plugins/midresource/plugin.go 86.48% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
+ Coverage   66.11%   66.16%   +0.04%     
==========================================
  Files         388      388              
  Lines       42425    42457      +32     
==========================================
+ Hits        28048    28090      +42     
+ Misses      12305    12298       -7     
+ Partials     2072     2069       -3     
Flag Coverage Δ
unittests 66.16% <86.48%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

implement mid-tier overcommitment in https://koordinator.sh/docs/designs/node-prediction/#mid-tier-overcommitment

```
Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid]
Unallocated[Mid] = max(NodeAllocatable - Allocated[Prod], 0)
```

Signed-off-by: j4ckstraw <[email protected]>
Signed-off-by: j4ckstraw <[email protected]>
@j4ckstraw j4ckstraw force-pushed the add-unallocated-into-mid-tier branch from fdb810a to ff65d69 Compare November 22, 2023 12:21
@j4ckstraw
Copy link
Contributor Author

maybe Allocatable[Mid]' := min(Reclaimable[Mid] + Unallocated[Mid], NodeAllocatable * thresholdRatio) is better than Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid]

@j4ckstraw j4ckstraw changed the title feat: add unallocated resource into mid resource [WIP] feat: add unallocated resource into mid resource Nov 23, 2023
@j4ckstraw j4ckstraw changed the title [WIP] feat: add unallocated resource into mid resource feat: add unallocated resource into mid resource Nov 23, 2023
@j4ckstraw j4ckstraw marked this pull request as draft November 23, 2023 01:36
@j4ckstraw
Copy link
Contributor Author

#1762

Copy link

stale bot commented Feb 26, 2024

This issue has been automatically marked as stale because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close
    Thank you for your contributions.

@j4ckstraw
Copy link
Contributor Author

/remove-lifecycle stale

Copy link

stale bot commented Jun 20, 2024

This issue has been automatically marked as stale because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close
    Thank you for your contributions.

Copy link

stale bot commented Jul 20, 2024

This issue has been automatically closed because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Reopen this PR with /reopen
    Thank you for your contributions.

@stale stale bot closed this Jul 20, 2024
@j4ckstraw
Copy link
Contributor Author

/reopen

@koordinator-bot koordinator-bot bot reopened this Jul 31, 2024
@koordinator-bot
Copy link

@j4ckstraw: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@j4ckstraw
Copy link
Contributor Author

/close

@koordinator-bot koordinator-bot bot closed this Aug 5, 2024
@koordinator-bot
Copy link

@j4ckstraw: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale stale bot removed the lifecycle/stale label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant