-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unallocated resource into mid resource #1750
feat: add unallocated resource into mid resource #1750
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8631493
to
855492b
Compare
855492b
to
fdb810a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1750 +/- ##
==========================================
+ Coverage 66.11% 66.16% +0.04%
==========================================
Files 388 388
Lines 42425 42457 +32
==========================================
+ Hits 28048 28090 +42
+ Misses 12305 12298 -7
+ Partials 2072 2069 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
implement mid-tier overcommitment in https://koordinator.sh/docs/designs/node-prediction/#mid-tier-overcommitment ``` Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid] Unallocated[Mid] = max(NodeAllocatable - Allocated[Prod], 0) ``` Signed-off-by: j4ckstraw <[email protected]>
Signed-off-by: j4ckstraw <[email protected]>
fdb810a
to
ff65d69
Compare
maybe |
This issue has been automatically marked as stale because it has not had recent activity.
|
/remove-lifecycle stale |
This issue has been automatically marked as stale because it has not had recent activity.
|
This issue has been automatically closed because it has not had recent activity.
|
/reopen |
@j4ckstraw: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@j4ckstraw: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
implement mid-tier overcommitment in https://koordinator.sh/docs/designs/node-prediction/#mid-tier-overcommitment
Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid] Unallocated[Mid] = max(NodeAllocatable - Allocated[Prod], 0)
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test