FCM 준비 #77
Open
FCM 준비 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 28, 2023 17:16
sookcha
reviewed
May 2, 2023
| @@ -1,3 +1,5 @@ | |||
| firebase-credential.json | |||
sookcha
reviewed
May 2, 2023
| _cred = { | ||
| "type": "service_account", | ||
| "project_id": "postona-6bfc9", | ||
| "private_key_id": os.environ.get('FIREBASE_PRIVATE_KEY_ID'), |
sookcha
reviewed
May 2, 2023
Comment on lines
+27
to
+28
| resp = messaging.send(message) | ||
| return resp |
There was a problem hiding this comment.
nit)
Suggested change
| resp = messaging.send(message) | |
| return resp | |
| return messaging.send(message) |
sookcha
reviewed
May 2, 2023
| @strawberry.type | ||
| class Mutation: | ||
| @strawberry.mutation | ||
| def send_fcm(self, info: Info, token: str, title: str, body: str) -> None: |
There was a problem hiding this comment.
알림 보내는 mutation 이 외부로 노출될 때, 우리가 내부적으로 FCM을 쓰는지 다른 방식을 쓰는지 알려줄 필요는 없으므로 이름을 바꾸면 좋을 것 같아요. 내부 구조를 노출하기 위해서가 아닌, 무엇을 하는 뮤테이션인지 설명하기 위해서요.
Suggested change
| def send_fcm(self, info: Info, token: str, title: str, body: str) -> None: | |
| def send_push_notification(self, info: Info, token: str, title: str, body: str) -> None: |
|
heroku 에 secret key base64 encode 시켜서 업데이트 해두었습니다. |
sookcha
reviewed
May 2, 2023
| "type": "service_account", | ||
| "project_id": "postona-6bfc9", | ||
| "private_key_id": os.environ.get('FIREBASE_PRIVATE_KEY_ID'), | ||
| "private_key": base64.decode(os.environ.get('FIREBASE_PRIVATE_KEY')), |
There was a problem hiding this comment.
Suggested change
| "private_key": base64.decode(os.environ.get('FIREBASE_PRIVATE_KEY')), | |
| "private_key": base64.b64decode(os.environ.get('FIREBASE_PRIVATE_KEY')).decode("UTF-8"), |
base64.b64decode 메소드를 사용해야할듯. 그러면 bytearray 가 응답됨. 그걸 다시 UTF-8 로 decode해줘야 정상적인 string이 나옴.
그냥 base64.decode 는 두 번째 인자로 output 이 들어가고, 파일로 결과가 써짐
내가 직접 테스트 해본 결과 잘 동작해. 나는 환경변수를 .env 파일에 넣어두었어.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
다른건 다 되는데 private key 부분이 잘 안되네용,,
Pycharm에서 환경 변수 자동으로 넣어주는 기능을 써서 그런가,,?