User 모델에 user가 마지막으로 사용한 persona의 닉네임을 저장하는 nullable field 추가 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sookcha
reviewed
Apr 11, 2023
| @@ -18,6 +18,9 @@ class User(AbstractBaseUser): | |||
| email = models.EmailField(verbose_name='유저의 이메일', unique=True) | |||
| username = models.CharField(max_length=254, unique=True) | |||
| signup_method = models.CharField(max_length=2, choices=SIGN_UP_METHOD_CHOICES, default=EMAIL) | |||
| # WARNING : 무결성을 보장하지는 않음 | |||
| last_used_persona_nickname = models.CharField(max_length=20, null=True, blank=True, default=None, | |||
There was a problem hiding this comment.
유저 모델에서 persona 의 존재를 알아야 하는 이유를 잘 이해하지 못했습니다. persona 테이블에 last_used_at 같은 컬럼을 하나 달고, 페르소나 전환 시 마다 갱신해주고
SELECT nickname FROM persona WHERE user_id = 1 ORDER BY last_used_at DESC LIMIT 1;graphql resolver 에서 이런 쿼리를 호출하도록 하면 어떤가요?
There was a problem hiding this comment.
적어도 nickname 을 2중 보관하는 지금보다는 깔끔한 구조라고 생각했습니다
There was a problem hiding this comment.
그거 좋네용!
명시적으로 어떤 페르소나를 쓰겠다~고 상태를 바꿔주는 API를 써야 할까요? 아니면 알아서 백엔드에서 페르소나에 대한 API가 호출될 때 갱신해줘야 할까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이런 이유로 추가했습니다.
현지는 내용 확인 해주고, 호성이가 PR 확인해서 merge해주세용~~