Skip to content

🐛 Bump agentic-controller/api so spec.execution.askUser round-trips - #1143

Merged
ibolton336 merged 1 commit into
konveyor:mainfrom
ibolton336:fix/bump-agentic-api-askuser
Sep 29, 2026
Merged

ibolton336 merged 1 commit into
konveyor:mainfrom
ibolton336:fix/bump-agentic-api-askuser

Conversation

@ibolton336

Copy link
Copy Markdown
Member

Summary

  • internal/api/agentic.go aliases the hub's AgentRun / AgentWorkflow / AgentWorkflowRun types to the upstream v1alpha1 types, so any field missing from the pinned agentic-controller/api snapshot is silently dropped on POST and omitted on GET.
  • The 2026-08-26 pin predates 🐛 ask_user is opt-in: spec.execution.askUser agentic-controller#242, which added ExecutionSpec.AskUser (the per-run opt-in for the ask_user tool). Move the pin to the 🌱 Support disconnected hub. #242 merge commit (38046470091c, the current tip of upstream main) so askUser survives the round trip.
  • The upstream diff between the two snapshots is additive only (new fields on agent_types.go, agentrun_types.go, agentworkflowrun_types.go, gateway_types.go, skillcard_types.go plus regenerated deepcopy). No hub code changes were needed.

Fixes #1142

release-0.11 carries the same pin; worth a cherry-pick if the 0.11 line is meant to let the console opt a run into asking questions. Console side: konveyor/tackle2-ui#3625.

Test plan

  • go build ./...
  • go vet ./internal/api/...
  • go test ./internal/api/... (with a placeholder internal/frontend/auth/content/dist so the embed resolves; that setup failure is pre-existing and unrelated)
  • Against a cluster on agentic-controller v0.11.0-beta.1+: POST /hub/agentic/agentruns with execution.askUser: true produces an AgentRun with the field set, and GET returns it.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 84a5b4f9-6b34-408b-a4df-d1d5854c4ab5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The hub binds AgentRun, AgentWorkflow and AgentWorkflowRun bodies into
the upstream v1alpha1 types, so any field the pinned snapshot lacks is
silently dropped on POST and omitted on GET. The 2026-08-26 pin predates
konveyor/agentic-controller#242, which added ExecutionSpec.AskUser, the
per-run opt-in for the ask_user tool. Move the pin to the konveyor#242 merge
commit so askUser survives the round trip.

Fixes konveyor#1142

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336
ibolton336 force-pushed the fix/bump-agentic-api-askuser branch from e046193 to 0dfa4e3 Compare September 25, 2026 00:32
@ibolton336
ibolton336 merged commit 43f4d85 into konveyor:main Sep 29, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agentic API: spec.execution.askUser is silently dropped because agentic-controller/api is pinned before it existed

2 participants