🐛 Bump agentic-controller/api so spec.execution.askUser round-trips - #1143
Merged
ibolton336 merged 1 commit intoSep 29, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 of 5 tasks
The hub binds AgentRun, AgentWorkflow and AgentWorkflowRun bodies into the upstream v1alpha1 types, so any field the pinned snapshot lacks is silently dropped on POST and omitted on GET. The 2026-08-26 pin predates konveyor/agentic-controller#242, which added ExecutionSpec.AskUser, the per-run opt-in for the ask_user tool. Move the pin to the konveyor#242 merge commit so askUser survives the round trip. Fixes konveyor#1142 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
fix/bump-agentic-api-askuser
branch
from
September 25, 2026 00:32
e046193 to
0dfa4e3
Compare
jortel
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/api/agentic.goaliases the hub's AgentRun / AgentWorkflow / AgentWorkflowRun types to the upstreamv1alpha1types, so any field missing from the pinnedagentic-controller/apisnapshot is silently dropped on POST and omitted on GET.ExecutionSpec.AskUser(the per-run opt-in for theask_usertool). Move the pin to the 🌱 Support disconnected hub. #242 merge commit (38046470091c, the current tip of upstreammain) soaskUsersurvives the round trip.agent_types.go,agentrun_types.go,agentworkflowrun_types.go,gateway_types.go,skillcard_types.goplus regenerated deepcopy). No hub code changes were needed.Fixes #1142
release-0.11carries the same pin; worth a cherry-pick if the 0.11 line is meant to let the console opt a run into asking questions. Console side: konveyor/tackle2-ui#3625.Test plan
go build ./...go vet ./internal/api/...go test ./internal/api/...(with a placeholderinternal/frontend/auth/content/distso the embed resolves; that setup failure is pre-existing and unrelated)v0.11.0-beta.1+:POST /hub/agentic/agentrunswithexecution.askUser: trueproduces an AgentRun with the field set, andGETreturns it.🤖 Generated with Claude Code