-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Add option to import json dump file (#291) #293
Conversation
Signed-off-by: Holger Bruch <[email protected]>
try { | ||
this.reader = new BufferedReader(new FileReader(filename)); | ||
} catch (FileNotFoundException e) { | ||
log.error("Json dump file '%1' not found", filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we should throw a RuntimeException to avoid usage of this connector.
} | ||
} | ||
|
||
public void setImporter(de.komoot.photon.Importer importer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be provided on construction and then importer and reader could be final?
Sanity of which form like empty content?
Which option do you prefer?
Can't judge about it. Both methods seems ok to me.
Yes, speed is not important for the first implementation IMO |
Have included some improvements of this in #438 |
This is a first attempt to provide a json dump import (see #291). Importing a json dump on my machine was about 10x faster than importing from nominatim.
However, there are some points I'd like to receive feedback on before doing a PR for merge: