Skip to content

feat(search): add person's name mapping and network optimization (#92)#93

Merged
komodgn merged 1 commit intodevelopfrom
feature/#92
Jan 23, 2026
Merged

feat(search): add person's name mapping and network optimization (#92)#93
komodgn merged 1 commit intodevelopfrom
feature/#92

Conversation

@komodgn
Copy link
Owner

@komodgn komodgn commented Jan 23, 2026

Summary by CodeRabbit

  • New Features
    • Enhanced search results now display user-friendly names instead of system identifiers, with improved filtering and deduplication of output.

✏️ Tip: You can customize this high-level summary in your review settings.

Verification

Before (Not Found) After

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The PR introduces a new suspend function getInputNameBySystemName to PersonRepository that maps system names to user-facing input names. SearchRepositoryImpl is updated to use this mapping in the focusingSearch flow to translate detected object system names before constructing external requests.

Changes

Cohort / File(s) Summary
PersonRepository Interface
core/data/api/.../repository/PersonRepository.kt
Adds new suspend function getInputNameBySystemName(systemName: String): String? for async name lookup
PersonRepository Implementation
core/data/impl/.../repository/PersonRepositoryImpl.kt
Implements getInputNameBySystemName by delegating to personDao.getInputNameByImageName within ioDispatcher context
Search Repository Integration
core/data/impl/.../repository/SearchRepositoryImpl.kt
Injects PersonRepository dependency; maps detected object system names to input names in focusingSearch; filters and deduplicates results; adds early return for empty mappedProperties; replaces direct detectionResponse usage with mapped properties

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 A new name-mapper hops into view,
System names transformed to user-friendly too,
Through ioDispatchers and repositories wide,
SearchResults dance with personalized pride! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding person name mapping functionality in the search repository and optimizing network usage by mapping system names to user-facing names.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Android CI Summary

Step Results:

  • Unit Test: ✅ Success (3m 7s)
  • Debug Build: ✅ Success (1m 11s)
  • Code Style Check: ✅ Success (3m 51s)

Total Time: 8m 9s

🎉 All steps completed successfully!

@komodgn komodgn merged commit 6b23021 into develop Jan 23, 2026
2 checks passed
@komodgn komodgn deleted the feature/#92 branch January 23, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant