Skip to content

feat(focusing-search): persist search state and selection data (#90)#91

Merged
komodgn merged 2 commits intodevelopfrom
feature/#90
Jan 21, 2026
Merged

feat(focusing-search): persist search state and selection data (#90)#91
komodgn merged 2 commits intodevelopfrom
feature/#90

Conversation

@komodgn
Copy link
Owner

@komodgn komodgn commented Jan 21, 2026

Summary by CodeRabbit

  • UI Updates

    • Updated search screen header label for improved clarity
  • Improvements

    • Enhanced state retention across app lifecycle transitions to better preserve user interactions and data

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the search feature with two changes: it updates state retention strategy in FocusingSearchPresenter from remember to rememberRetained for three state variables, and updates the header label text from Korean "포커싱 검색" to "드래그 검색".

Changes

Cohort / File(s) Summary
State Retention Update
feature/search/src/main/java/com/metasearch/android/feature/search/focusing/FocusingSearchPresenter.kt
Replaces remember { mutableStateOf(...) } with rememberRetained { mutableStateOf(...) } for imageUriString, circles, and searchResult state variables to improve state persistence across lifecycle changes
UI Label Update
feature/search/src/main/res/values/strings.xml
Updates focusing_search_screen_header string resource value from "포커싱 검색" to "드래그 검색"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • komodgn/meta-android#71: Modifies the same FocusingSearchPresenter.kt file for state-event and toast handling, sharing the same code location.
  • komodgn/meta-android#89: Also replaces remember with rememberRetained pattern in presenter components for improved UI state persistence across lifecycle events.

Poem

🐰 The state now stays / Through lifecycle's dance, / Retained with care— / And labels speak true, / "드래그" whispers clear— / A hop forward! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing remember with rememberRetained to persist search state and selection data across lifecycle changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Android CI Summary

Step Results:

  • Unit Test: ✅ Success (3m 16s)
  • Debug Build: ✅ Success (1m 7s)
  • Code Style Check: ✅ Success (3m 49s)

Total Time: 8m 12s

🎉 All steps completed successfully!

@komodgn komodgn merged commit fa5aaa9 into develop Jan 21, 2026
2 checks passed
@komodgn komodgn deleted the feature/#90 branch January 21, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant