refactor: split SearchBar into stateless and stateful components (#86)#87
Merged
refactor: split SearchBar into stateless and stateful components (#86)#87
Conversation
- Create MetaSearchSearchBar as a reusable stateless component - Implement state hoisting for NLSearchTextField to improve encapsulation - Optimize rendering performance by isolating recomposition scope
📝 WalkthroughWalkthroughThis PR introduces a new reusable MetaSearchSearchBar Compose component and refactors the NLSearchTextField to use it. The event handling flow is consolidated from separate input-change and search callbacks into a single search action that emits both events sequentially. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@core/ui/src/main/java/com/metasearch/android/core/ui/component/MetaSearchSearchBar.kt`:
- Around line 75-89: The Icon in MetaSearchSearchBar.kt uses a hardcoded
contentDescription ("Search Icon"); extract this to a string resource and
reference it via stringResource in the composable. Add a string entry (e.g.
name="search_icon_content_description" value="Search") to your module's
strings.xml and replace the hardcoded contentDescription in the Icon call with
stringResource(R.string.search_icon_content_description) (keep the Icon,
onSearchClick, and Modifier usage unchanged).
Comment on lines
+75
to
+89
| Icon( | ||
| painter = painterResource(R.drawable.ic_search_line), | ||
| contentDescription = "Search Icon", | ||
| modifier = Modifier | ||
| .size( | ||
| MetaSearchTheme.spacing.spacing6, | ||
| ) | ||
| .clickable( | ||
| indication = null, | ||
| interactionSource = remember { MutableInteractionSource() }, | ||
| ) { | ||
| onSearchClick() | ||
| }, | ||
| tint = Neutral500, | ||
| ) |
There was a problem hiding this comment.
Hardcoded content description should be a string resource.
The contentDescription = "Search Icon" on line 77 should be extracted to a string resource for proper internationalization support.
Suggested fix
Icon(
painter = painterResource(R.drawable.ic_search_line),
- contentDescription = "Search Icon",
+ contentDescription = stringResource(R.string.search_icon_content_description),
modifier = ModifierAdd the corresponding string resource in core/ui/src/main/res/values/strings.xml:
<string name="search_icon_content_description">Search</string>🤖 Prompt for AI Agents
In
`@core/ui/src/main/java/com/metasearch/android/core/ui/component/MetaSearchSearchBar.kt`
around lines 75 - 89, The Icon in MetaSearchSearchBar.kt uses a hardcoded
contentDescription ("Search Icon"); extract this to a string resource and
reference it via stringResource in the composable. Add a string entry (e.g.
name="search_icon_content_description" value="Search") to your module's
strings.xml and replace the hardcoded contentDescription in the Icon call with
stringResource(R.string.search_icon_content_description) (keep the Icon,
onSearchClick, and Modifier usage unchanged).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.
Verification