Skip to content

구분선 공통 컴포넌트를 사용하여 코드 중복을 제거한다 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komodgn merged 2 commits into from
Jan 7, 2026
Merged

구분선 공통 컴포넌트를 사용하여 코드 중복을 제거한다 #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57d9892
feat: 구분선 공통 컴포넌트 추가 (#64)
komodgn Jan 7, 2026
25a8bf3
refactor: 공통 구분선 컴포넌트를 적용하여 중복 코드 제거 (#64)
komodgn Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions core/ui/src/main/java/com/example/metasearch/core/ui/component/MetaSearchDivider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package com.example.metasearch.core.ui.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme

@Composable
fun MetaSearchDivider(
modifier: Modifier = Modifier,
) {
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
}

@ComponentPreview
@Composable
private fun MetaSearchDividerPreview() {
MetaSearchTheme {
MetaSearchDivider()
}
}
10 changes: 2 additions & 8 deletions .../src/main/java/com/example/metasearch/feature/detail/graph/component/GraphDetailHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package com.example.metasearch.feature.detail.graph.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.material3.Icon
Expand All @@ -18,9 +16,9 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextAlign
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.detail.R

@Composable
Expand Down Expand Up @@ -54,11 +52,7 @@ fun GraphDetailHeader(
modifier = Modifier.width(MetaSearchTheme.spacing.spacing10),
)
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
11 changes: 2 additions & 9 deletions ...rc/main/java/com/example/metasearch/feature/detail/person/component/PersonDetailHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package com.example.metasearch.feature.detail.person.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.material3.Icon
Expand All @@ -18,9 +15,9 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.detail.R

@Composable
Expand Down Expand Up @@ -61,11 +58,7 @@ fun PersonDetailHeader(
)
}
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
10 changes: 2 additions & 8 deletions .../src/main/java/com/example/metasearch/feature/detail/photo/component/PhotoDetailHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package com.example.metasearch.feature.detail.photo.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.material3.Icon
Expand All @@ -18,9 +16,9 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextAlign
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.detail.R

@Composable
Expand Down Expand Up @@ -54,11 +52,7 @@ fun PhotoDetailHeader(
modifier = Modifier.width(MetaSearchTheme.spacing.spacing10),
)
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
11 changes: 2 additions & 9 deletions feature/graph/src/main/java/com/example/metasearch/feature/graph/component/GraphHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
package com.example.metasearch.feature.graph.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.graph.R

@Composable
Expand All @@ -34,11 +31,7 @@ fun GraphHeader(
color = Neutral800,
)
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
10 changes: 2 additions & 8 deletions feature/home/src/main/java/com/example/metasearch/feature/home/component/HomeHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package com.example.metasearch.feature.home.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.material3.CircularProgressIndicator
Expand All @@ -19,9 +17,9 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.home.R

@Composable
Expand Down Expand Up @@ -59,11 +57,7 @@ fun HomeHeader(
}
}
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
11 changes: 2 additions & 9 deletions feature/person/src/main/java/com/example/metasearch/feature/person/component/PersonHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
package com.example.metasearch.feature.person.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.person.R

@Composable
Expand All @@ -34,11 +31,7 @@ fun PersonHeader(
color = Neutral800,
)
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
10 changes: 2 additions & 8 deletions ...ain/java/com/example/metasearch/feature/search/focusing/component/FocusingSearchHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package com.example.metasearch.feature.search.focusing.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.material3.Icon
Expand All @@ -18,9 +16,9 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextAlign
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.search.R

@Composable
Expand Down Expand Up @@ -54,11 +52,7 @@ fun FocusingSearchHeader(
modifier = Modifier.width(MetaSearchTheme.spacing.spacing10),
)
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down
11 changes: 2 additions & 9 deletions ...earch/src/main/java/com/example/metasearch/feature/search/nls/component/NLSearchHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
package com.example.metasearch.feature.search.nls.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import com.example.metasearch.core.designsystem.annotation.ComponentPreview
import com.example.metasearch.core.designsystem.theme.LightGrey
import com.example.metasearch.core.designsystem.theme.MetaSearchTheme
import com.example.metasearch.core.designsystem.theme.Neutral800
import com.example.metasearch.core.ui.component.MetaSearchDivider
import com.example.metasearch.feature.search.R

@Composable
Expand All @@ -34,11 +31,7 @@ fun NLSearchHeader(
color = Neutral800,
)
}
Spacer(
modifier = modifier.fillMaxWidth()
.height(MetaSearchTheme.spacing.spacing05)
.background(LightGrey),
)
MetaSearchDivider()
}
}

Expand Down