Skip to content

인물 합치기 완료 후 뒤로가기 시 빈 화면이 노출되는 이슈를 해결한다 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komodgn merged 1 commit into from
Jan 6, 2026
Merged

인물 합치기 완료 후 뒤로가기 시 빈 화면이 노출되는 이슈를 해결한다 #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...etail/src/main/java/com/example/metasearch/feature/detail/person/PersonDetailPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.example.metasearch.feature.detail.person

import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableLongStateOf
Expand Down Expand Up @@ -62,6 +63,16 @@ class PersonDetailPresenter @AssistedInject constructor(
var showMergeConfirmDialog by rememberRetained { mutableStateOf(false) }
var showPhotoSelectDialog by rememberRetained { mutableStateOf(false) }

var isInitialized by remember { mutableStateOf(false) }

LaunchedEffect(person) {
if (person != null) {
isInitialized = true
} else if (isInitialized && !isLoading) {
navigator.pop()
}
}
Comment on lines +68 to +74
Copy link

@coderabbitai coderabbitai bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

LaunchedEffect must also key on isLoading to prevent race condition.

The effect only triggers when person changes, not when isLoading changes. If the person becomes null while isLoading is true (during the merge at lines 129-132), the navigation check will fail. When isLoading later becomes false, the effect won't re-trigger, leaving the user on an empty screen—the exact issue this PR aims to fix.

🔎 Proposed fix 
-        LaunchedEffect(person) {
+        LaunchedEffect(person, isLoading) {
             if (person != null) {
                 isInitialized = true
             } else if (isInitialized && !isLoading) {
                 navigator.pop()
             }
         }
🤖 Prompt for AI Agents 
In
@feature/detail/src/main/java/com/example/metasearch/feature/detail/person/PersonDetailPresenter.kt
around lines 68 - 74, The LaunchedEffect in PersonDetailPresenter currently only
keys on person so it won't re-run when isLoading flips, causing a race where
person becomes null during loading and navigator.pop() never runs; update the
LaunchedEffect to key on both person and isLoading (e.g., LaunchedEffect(person,
isLoading)) and keep the existing logic that sets isInitialized when person !=
null and calls navigator.pop() when person == null && isInitialized &&
!isLoading so the effect will re-evaluate after the merge at the code altering
isLoading (the merge around lines 129-132) and correctly navigate away.


suspend fun savePersonInfo() {
val currentPerson = person ?: return

Expand Down