Skip to content

fix-script.js-runtime-crash#858

Open
Sahasra-iiits wants to merge 1 commit into
komalharshita:mainfrom
Sahasra-iiits:fix/runtime-crash
Open

fix-script.js-runtime-crash#858
Sahasra-iiits wants to merge 1 commit into
komalharshita:mainfrom
Sahasra-iiits:fix/runtime-crash

Conversation

@Sahasra-iiits

Copy link
Copy Markdown

Summary [required]

This PR fixes a critical JavaScript syntax error present in the live production deployment that was preventing the main application script from executing correctly. Because of this, responsiveness along with many event listeners were stopping working.

While working on a different issue, I noticed that the production site was throwing a runtime exception in the browser console:

Uncaught SyntaxError: Unexpected token ')' (script.js:1076)

Since this error affects the live deployment and halts subsequent JavaScript execution, I investigated the issue immediately and submitted a fix to restore normal application functionality. Although Issue #855 was not assigned to me, I considered it important to address promptly because it impacts all users accessing the production site.

Related Issue [required]

Closes #855

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
static/script.js Fixed mismatched closing parenthesis causing Unexpected token ')' syntax error many different lines and restructured the code without changing any functionality

How to Test This PR [required]

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and check console.
  5. Run the tests: python tests/test_basic.py

Expected test output:

27 passed, 0 failed out of 27 tests

Test Results [required]

  PASS  test_projects_json_loads
  PASS  test_each_project_has_required_fields
  PASS  test_find_project_by_id_found
  PASS  test_find_project_by_id_missing
  PASS  test_parse_skills_basic
  PASS  test_parse_skills_empty_string
  PASS  test_parse_skills_single_entry
  PASS  test_score_single_project_full_match
  PASS  test_score_single_project_no_match
  PASS  test_get_recommendations_returns_results
  PASS  test_get_recommendations_max_three
  PASS  test_get_recommendations_no_match_returns_empty
  PASS  test_get_recommendations_result_format
  PASS  test_validate_all_valid
  PASS  test_validate_missing_skills
  PASS  test_validate_missing_level
  PASS  test_validate_missing_interest
  PASS  test_validate_missing_time
  PASS  test_validate_all_missing
  PASS  test_home_route
  PASS  test_recommend_api_valid
  PASS  test_recommend_api_missing_field
  PASS  test_recommend_api_empty_body
  PASS  test_project_detail_found
  PASS  test_project_detail_not_found
  PASS  test_view_code_found
  PASS  test_download_code_found

27 passed, 0 failed out of 27 tests

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

While working on another contribution, I discovered this production-breaking issue and verified that it was reproducible on the live deployment.

Although Issue #855 was not formally assigned to me, I submitted this fix because the error affects the production environment and prevents proper JavaScript execution across the application. The change is minimal, isolated, and focused solely on resolving the reported syntax exception.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

@Sahasra-iiits is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc-2026 type:bug Something isn't working type:accessibility ui and removed type:bug Something isn't working gssoc-2026 labels Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Live site runtime crash due to Uncaught SyntaxError (Unexpected token ')') in script.js

1 participant