RTL Support #34
Open
RTL Support #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added RTL support
added RTL support
added RTL support
added RTL support
|
Not quite sure I understood the purpose of this PR. As for me, the |
buraks
reviewed
Jan 16, 2025
| const App = () => { | ||
| const { width, height } = useWindowDimensions(); | ||
| const scrollX = useRef(new Animated.Value(0)).current; | ||
| const scrollX = useRef(new Animated.Value(rtl ? width * (pages.length - 1) : 0)).current; |
There was a problem hiding this comment.
Thank you for the PR, this helped me save a lot of time. I just used bun patch to generate a patch for my app.
I also needed to change the default value depending on iOS/Android. For some reason on iOS the slider still works from LTR while the ScrollView works RTL, so I used 0 for iOS and windowWidth * (pageLengt-1) for Android.
Do you know how to make the indicator work RTL on iOS as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.