Skip to content

fix(editor): make manual text OCR-ready - #1031

Open
atirna wants to merge 2 commits into
koharu-rs:mainfrom
atirna:fix/manual-text-ocr
Open

fix(editor): make manual text OCR-ready#1031
atirna wants to merge 2 commits into
koharu-rs:mainfrom
atirna:fix/manual-text-ocr

Conversation

@atirna

@atirna atirna commented Sep 1, 2026

Copy link
Copy Markdown

Summary

Manual text now creates the same text-region relationships as detected text. Empty manual text can enter OCR, and its frame has the existing automatic placement with a user override after moving or resizing.

Related issue

Fixes #994

Verification

  • cargo test -p koharu-app manual_text_uses_an_editable_ocr_region

AI assistance

I used AI assistance to trace the existing scene relationships and implement this focused change; I reviewed and own the patch.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for your first PR to Koharu.

Please review our contribution guide before review:
https://koharu.rs/development/contributing/

In the PR description, include:

  • what changed
  • any user-visible behavior differences
  • how you verified the change

If AI substantially helped design or implement the patch, disclose the extent and purpose of that assistance. A human contributor must personally review, understand, and take responsibility for every submission.

@ZenoArrows

Copy link
Copy Markdown

While the visual style of the text boxes has changed the manually placed text boxes are still not picked up by OCR. Could you verify your change again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No OCR for manual placed frames; manual placed frames can't be changed

2 participants