fix(editor): make manual text OCR-ready - #1031
Open
atirna wants to merge 2 commits into
Open
Conversation
atirna
requested review from
fffonion,
karrot0,
liksunrice and
mayocream
as code owners
September 1, 2026 17:33
Contributor
|
Thanks for your first PR to Koharu. Please review our contribution guide before review: In the PR description, include:
If AI substantially helped design or implement the patch, disclose the extent and purpose of that assistance. A human contributor must personally review, understand, and take responsibility for every submission. |
|
While the visual style of the text boxes has changed the manually placed text boxes are still not picked up by OCR. Could you verify your change again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual text now creates the same text-region relationships as detected text. Empty manual text can enter OCR, and its frame has the existing automatic placement with a user override after moving or resizing.
Related issue
Fixes #994
Verification
cargo test -p koharu-app manual_text_uses_an_editable_ocr_regionAI assistance
I used AI assistance to trace the existing scene relationships and implement this focused change; I reviewed and own the patch.