feat(rendering): Added global overrides for font color, font weight and font border width - #1024
Open
Hams-01 wants to merge 3 commits into
Open
feat(rendering): Added global overrides for font color, font weight and font border width#1024Hams-01 wants to merge 3 commits into
Hams-01 wants to merge 3 commits into
Conversation
Hams-01
requested review from
fffonion,
karrot0,
liksunrice and
mayocream
as code owners
August 31, 2026 13:07
Contributor
|
Thanks for your first PR to Koharu. Please review our contribution guide before review: In the PR description, include:
If AI substantially helped design or implement the patch, disclose the extent and purpose of that assistance. A human contributor must personally review, understand, and take responsibility for every submission. |
mayocream
requested changes
Aug 31, 2026
mayocream
left a comment
mayocream
left a comment
Member
There was a problem hiding this comment.
We should fix the auto color detection & border detection instead of set a global overrides.
Both is good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Font Border width, color and weight can now be toggled between auto and a custom value.
Issue
Found border width to be unpredictable on small, unconventional text like sfx. Black text with a thin white margin is acceptable on most backgrounds.