Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 page landing seo #339

Merged
merged 5 commits into from
Oct 7, 2024
+9 −11
Merged

🔧 page landing seo #339

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
654ebfa
🔧 page landing seo
roiLeo Oct 1, 2024
cbc7055
Merge branch 'main' into fix/landing/seo
roiLeo Oct 1, 2024
a4e1bbb
Update ogImage to use constant
roiLeo Oct 1, 2024
7884586
Update twitterImage to use constant
roiLeo Oct 1, 2024
cab6939
fix(seo): correct duplicate meta tag entries on index page
preschian Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
🔧 page landing seo
@roiLeo
roiLeo committed Oct 1, 2024
commit 654ebfae003aaf1867e4296e5c106e2224511565
27 changes: 14 additions & 13 deletions ogi/pages/index.vue
View file
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
<template>
<div>
<NuxtWelcome />
</div>
<div></div>
</template>

<script lang="ts" setup>
const route = useRoute()

const { image, text } = route.query

defineOgImage({
component: 'base',
props: {
text: text,
image: image,
},
useSeoMeta({
title: 'KodaDot - Your Generative Art Marketplace',
viewport: 'width=device-width, initial-scale=1',
description: 'One Stop NFT Shop on Polkadot',
ogTitle: 'KodaDot - NFT Market Explorer',
ogDescription: 'One Stop NFT Shop on Polkadot',
ogType: 'website',
ogImage: 'https://koda.art/k_card.png',
twitterCard: 'summary_large_image',
twitterTitle: 'KodaDot - NFT Market Explorer',
twitterDescription: 'One Stop NFT Shop on Polkadot',
twitterImage: 'https://koda.art/k_card.png',
twitterSite: '@KodaDot'
})
</script>

Unchanged files with check annotations Beta

View file
services/image/src/tests/type-endpoint.test.ts
expect(res2.headers.get('content-type')).toBe('image/png')
const data = await res2.blob()
expect(data).toMatchInlineSnapshot(`

Check failure on line 69 in services/image/src/tests/type-endpoint.test.ts

GitHub Actions / test-image-workers

src/tests/type-endpoint.test.ts > type-endpoint - 302 - image 

Error: Snapshot `type-endpoint - 302 - image 1` mismatched

- Expected
+ Received

  Blob {
    Symbol(kHandle): Blob {},
-   Symbol(kLength): 86738,
+   Symbol(kLength): 86717,
    Symbol(kType): "image/png",
  }

 ❯ src/tests/type-endpoint.test.ts:69:16
Blob {
Symbol(kHandle): Blob {},
Symbol(kLength): 86738,
expect(res.headers.get('content-type')).toBe('image/png')
const data = await res.blob()
expect(data).toMatchInlineSnapshot(`

Check failure on line 88 in services/image/src/tests/type-endpoint.test.ts

GitHub Actions / test-image-workers

src/tests/type-endpoint.test.ts > type-endpoint - 200 - image - original 

Error: Snapshot `type-endpoint - 200 - image - original 1` mismatched

- Expected
+ Received

  Blob {
    Symbol(kHandle): Blob {},
-   Symbol(kLength): 86783,
+   Symbol(kLength): 86670,
    Symbol(kType): "image/png",
  }

 ❯ src/tests/type-endpoint.test.ts:88:16
Blob {
Symbol(kHandle): Blob {},
Symbol(kLength): 86783,