feat: New swap tables & Swap Modal follow up #11389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ref: remove TradeInteraction
# Conflicts: # i18n/locales/en.json
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hassnian
changed the title
✅ Deploy Preview for polkadot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hassnian
requested review from
preschian and
Jarsen136
and removed request for
a team
|
cc @Jarsen136 @preschian pls review 🙏 |
preschian
approved these changes
Feb 13, 2025
|
|
||
| const { urlPrefix } = usePrefix() | ||
|
|
||
| const itemPath = computed(() => `/${urlPrefix.value}/gallery/${props.id}`) |
| @@ -13,23 +13,30 @@ | |||
| v-if="trade.isAnyTokenInCollectionDesired" | |||
| :trade="trade" | |||
| :send-item="sendItem" | |||
| :title="desiredTitle" | |||
There was a problem hiding this comment.
props required string, but desiredTitle can be string | undefined
|
cc @hassnian can you please check comments? |
# Conflicts: # components/shared/gallery/NeoTag.vue
|
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Context
after #11319
Needs Design check
Screenshot 📸
Swaps
Offer