fix: RequestValidateFacade Variable could not be converted to string #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when RequestValidateFacade is parsing controller methods in specific context.
Given this exemple :
When generating doc with artisan
RequestValidateFacade
will end in the exceptionBecause line 28 is calling toString method on
$expr->class
but it has no toString method inPhpParser\Node\Expr\Variable
object. It is$model = $modelType::findOrFail($val);
which causes the problem.Thi PR ensure we check class name onto the right objects to avoid this bug.