Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 84 upgrade #922

Open
wants to merge 13 commits into
base: v5
Choose a base branch
from
Open

Php 84 upgrade #922

wants to merge 13 commits into from

Conversation

markwalet
Copy link
Contributor

The dev dependencies were a bit outdated. I've updated them where I could without breaking tests, but especially in the lower versions it was unclear to me which versions were still supported.

Besides the dependency upgrades, I've resolved the deprecations warnings for PHP 8.4.

@shalvah
Copy link
Contributor

shalvah commented Nov 29, 2024

Thanks!

I'll be fine with dropping support for PHP 8.0 and dingo/api; I think we've done a good job of supporting them for a while now.

@markwalet
Copy link
Contributor Author

I'm not familiar with dingo, and the 3 different composer files don't really help with figuring out what is required and what is not. I'm used to using composer update --prefer-lowest when testing my minimal version constraints.

You can find an example here. But I'm not sure if we should fit this into this merge request at all or create a separate issue for that. What do you think?

@markwalet
Copy link
Contributor Author

Any update on this? What do you want me to do?

@markwalet
Copy link
Contributor Author

I've removed the dependency changes completely in favor of just doing the code changes in a separate merge request to improve reviewability.

#929

@shalvah
Copy link
Contributor

shalvah commented Dec 30, 2024

I've been in the hospital/on recovery. I'll look at this soon. My plan is to create a branch for the next major version and do the ground work there, then point your PRs to it.

@shalvah shalvah changed the base branch from master to vNext January 18, 2025 20:33
@shalvah
Copy link
Contributor

shalvah commented Jan 18, 2025

Hmm, I think I may close this PR. I've dropped support for PHP 8, Dingo and Lumen on the vNext branch, and pointed this to it, but some tests still fail. Current dependencies seem to work fine on PHP 8.1 to 8.4.

@shalvah
Copy link
Contributor

shalvah commented Jan 18, 2025

Okay, ,they seem to work on all versions but 8.1 (code coverage is broken). Could you check that?

It's not really a priority, anyway, since it's only dev deps.

@markwalet
Copy link
Contributor Author

Unfortunately I can't get the dependencies to work. It's a bit of a mess with a separate lowest.composer.json and I can't wrap my head around it.

Even with the tests being successful, it seems like the coverage statistics are failing. On my own packages I normally only collect coverage data for the latest stable php/laravel version. Maybe that could help? It all just becomes a bit more complicated when you try to run coverage on pestphp V1 and V2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants