Refactor tests

knuckleswtf · May 8, 2020 · a81b4a8 · a81b4a8
1 parent 6b20e8c
commit a81b4a8
Show file tree

Hide file tree

Showing 15 changed files with 27 additions and 32 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,6 @@
 .DS_Store
 composer.lock
-*.composer.lock
+composer.dingo.lock
 .php_cs.cache
 /vendor/
 public/

diff --git a/phpunit.xml b/phpunit.xml
@@ -10,24 +10,24 @@
          processIsolation="false"
          stopOnFailure="false">
     <testsuites>
+        <testsuite name="Full Test">
+            <file>tests/GenerateDocumentationTest.php</file>
+        </testsuite>
         <testsuite name="Generator Tests">
             <file>tests/Unit/DingoGeneratorTest.php</file>
             <file>tests/Unit/LaravelGeneratorTest.php</file>
             <file>tests/Unit/GeneratorPluginSystemTest.php</file>
         </testsuite>
+        <testsuite name="Strategies">
+            <directory>tests/Strategies</directory>
+        </testsuite>
         <testsuite name="RouteMatcher Tests">
             <file>tests/Unit/RouteMatcherDingoTest.php</file>
             <file>tests/Unit/RouteMatcherTest.php</file>
         </testsuite>
-        <testsuite name="Full Test">
-            <file>tests/GenerateDocumentationTest.php</file>
-        </testsuite>
-        <testsuite name="Postman Collection Test">
+        <testsuite name="Other Unit Tests">
             <file>tests/Unit/PostmanCollectionWriterTest.php</file>
-            <file>tests/Tools/AnnotationParserTest.php</file>
-        </testsuite>
-        <testsuite name="Strategies">
-            <directory>tests/Extracting/Strategies</directory>
+            <file>tests/Unit/AnnotationParserTest.php</file>
         </testsuite>
     </testsuites>
     <filter>

diff --git a/...odyParameters/GetFromBodyParamTagTest.php → ...odyParameters/GetFromBodyParamTagTest.php b/...odyParameters/GetFromBodyParamTagTest.php → ...odyParameters/GetFromBodyParamTagTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\BodyParameters;
+namespace Knuckles\Scribe\Tests\Strategies\BodyParameters;
 
 use Illuminate\Routing\Route;
 use Knuckles\Scribe\Extracting\Strategies\BodyParameters\GetFromBodyParamTag;

diff --git a/...BodyParameters/GetFromFormRequestTest.php → ...BodyParameters/GetFromFormRequestTest.php b/...BodyParameters/GetFromFormRequestTest.php → ...BodyParameters/GetFromFormRequestTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\BodyParameters;
+namespace Knuckles\Scribe\Tests\Strategies\BodyParameters;
 
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\ValidationException;

diff --git a/...ategies/Metadata/GetFromDocBlocksTest.php → ...ategies/Metadata/GetFromDocBlocksTest.php b/...ategies/Metadata/GetFromDocBlocksTest.php → ...ategies/Metadata/GetFromDocBlocksTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\Metadata;
+namespace Knuckles\Scribe\Tests\Strategies\Metadata;
 
 use Knuckles\Scribe\Extracting\Strategies\Metadata\GetFromDocBlocks;
 use Knuckles\Scribe\Tools\DocumentationConfig;

diff --git a/...ryParameters/GetFromQueryParamTagTest.php → ...ryParameters/GetFromQueryParamTagTest.php b/...ryParameters/GetFromQueryParamTagTest.php → ...ryParameters/GetFromQueryParamTagTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\QueryParameters;
+namespace Knuckles\Scribe\Tests\Strategies\QueryParameters;
 
 use Illuminate\Routing\Route;
 use Knuckles\Scribe\Extracting\Strategies\QueryParameters\GetFromQueryParamTag;

diff --git a/...nseFields/GetFromResponseFieldTagTest.php → ...nseFields/GetFromResponseFieldTagTest.php b/...nseFields/GetFromResponseFieldTagTest.php → ...nseFields/GetFromResponseFieldTagTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\ResponseFields;
+namespace Knuckles\Scribe\Tests\Strategies\ResponseFields;
 
 use Knuckles\Scribe\Extracting\Strategies\ResponseFields\GetFromResponseFieldTag;
 use Knuckles\Scribe\Tools\DocumentationConfig;

diff --git a/...trategies/Responses/ResponseCallsTest.php → ...trategies/Responses/ResponseCallsTest.php b/...trategies/Responses/ResponseCallsTest.php → ...trategies/Responses/ResponseCallsTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\Responses;
+namespace Knuckles\Scribe\Tests\Strategies\Responses;
 
 use Dingo\Api\Routing\Router;
 use Illuminate\Routing\Route;
@@ -9,10 +9,8 @@
 use Knuckles\Scribe\Tests\Fixtures\TestController;
 use Knuckles\Scribe\Tools\DocumentationConfig;
 use DMS\PHPUnitExtensions\ArraySubset\ArraySubsetAsserts;
-use Knuckles\Scribe\Tools\Flags;
 use Orchestra\Testbench\TestCase;
 use Illuminate\Support\Facades\Route as LaravelRouteFacade;
-use Dingo\Api\Routing\Router as DingoRouter;
 
 class ResponseCallsTest extends TestCase
 {

diff --git a/...gies/Responses/UseApiResourceTagsTest.php → ...gies/Responses/UseApiResourceTagsTest.php b/...gies/Responses/UseApiResourceTagsTest.php → ...gies/Responses/UseApiResourceTagsTest.php
@@ -1,10 +1,8 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\Responses;
+namespace Knuckles\Scribe\Tests\Strategies\Responses;
 
-use Knuckles\Scribe\Extracting\Generator;
 use Knuckles\Scribe\Extracting\Strategies\Responses\UseApiResourceTags;
-use Knuckles\Scribe\Extracting\Strategies\Responses\UseTransformerTags;
 use Knuckles\Scribe\ScribeServiceProvider;
 use Knuckles\Scribe\Tests\Fixtures\TestUser;
 use Knuckles\Scribe\Tools\DocumentationConfig;

diff --git a/...gies/Responses/UseResponseFileTagTest.php → ...gies/Responses/UseResponseFileTagTest.php b/...gies/Responses/UseResponseFileTagTest.php → ...gies/Responses/UseResponseFileTagTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\Responses;
+namespace Knuckles\Scribe\Tests\Strategies\Responses;
 
 use Knuckles\Scribe\Extracting\Strategies\Responses\UseResponseFileTag;
 use Knuckles\Scribe\ScribeServiceProvider;
@@ -30,8 +30,8 @@ protected function getPackageProviders($app)
      */
     public function allows_multiple_responsefile_tags_for_multiple_statuses_and_scenarios(array $tags, array $expected)
     {
-        $filePath =  __DIR__ . '/../../../Fixtures/response_test.json';
-        $filePath2 =  __DIR__ . '/../../../Fixtures/response_error_test.json';
+        $filePath =  __DIR__ . '/../../Fixtures/response_test.json';
+        $filePath2 =  __DIR__ . '/../../Fixtures/response_error_test.json';
 
         copy($filePath, storage_path('response_test.json'));
         copy($filePath2, storage_path('response_error_test.json'));
@@ -60,7 +60,7 @@ public function allows_multiple_responsefile_tags_for_multiple_statuses_and_scen
     public function can_add_or_replace_key_value_pair_in_response_file()
     {
 
-        $filePath = __DIR__ . '/../../../Fixtures/response_test.json';
+        $filePath = __DIR__ . '/../../Fixtures/response_test.json';
         copy($filePath, storage_path('response_test.json'));
 
         $strategy = new UseResponseFileTag(new DocumentationConfig([]));

diff --git a/...rategies/Responses/UseResponseTagTest.php → ...rategies/Responses/UseResponseTagTest.php b/...rategies/Responses/UseResponseTagTest.php → ...rategies/Responses/UseResponseTagTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\Responses;
+namespace Knuckles\Scribe\Tests\Strategies\Responses;
 
 use Knuckles\Scribe\Extracting\Strategies\Responses\UseResponseTag;
 use Knuckles\Scribe\Tools\DocumentationConfig;

diff --git a/...gies/Responses/UseTransformerTagsTest.php → ...gies/Responses/UseTransformerTagsTest.php b/...gies/Responses/UseTransformerTagsTest.php → ...gies/Responses/UseTransformerTagsTest.php
@@ -1,10 +1,9 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\Responses;
+namespace Knuckles\Scribe\Tests\Strategies\Responses;
 
 use Knuckles\Scribe\Extracting\Strategies\Responses\UseTransformerTags;
 use Knuckles\Scribe\ScribeServiceProvider;
-use Knuckles\Scribe\Tests\Fixtures\TestModel;
 use Knuckles\Scribe\Tests\Fixtures\TestUser;
 use Knuckles\Scribe\Tools\DocumentationConfig;
 use Mpociot\Reflection\DocBlock\Tag;

diff --git a/.../UrlParameters/GetFromUrlParamTagTest.php → .../UrlParameters/GetFromUrlParamTagTest.php b/.../UrlParameters/GetFromUrlParamTagTest.php → .../UrlParameters/GetFromUrlParamTagTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Knuckles\Scribe\Tests\Extracting\Strategies\UrlParameters;
+namespace Knuckles\Scribe\Tests\Strategies\UrlParameters;
 
 use Knuckles\Scribe\Extracting\Strategies\UrlParameters\GetFromUrlParamTag;
 use Knuckles\Scribe\Tools\DocumentationConfig;

diff --git a/tests/Tools/AnnotationParserTest.php → tests/Unit/AnnotationParserTest.php b/tests/Tools/AnnotationParserTest.php → tests/Unit/AnnotationParserTest.php
@@ -1,7 +1,8 @@
 <?php
 
-namespace Knuckles\Scribe\Tools;
+namespace Knuckles\Scribe\Tests\Unit;
 
+use Knuckles\Scribe\Tools\AnnotationParser;
 use PHPUnit\Framework\TestCase;
 
 class AnnotationParserTest extends TestCase

diff --git a/tests/Unit/GeneratorPluginSystemTestCase.php b/tests/Unit/GeneratorPluginSystemTestCase.php
@@ -4,13 +4,11 @@
 
 use DMS\PHPUnitExtensions\ArraySubset\ArraySubsetAsserts;
 use Illuminate\Routing\Route;
-use Knuckles\Scribe\ScribeServiceProvider;
 use Knuckles\Scribe\Extracting\Generator;
 use Knuckles\Scribe\Extracting\Strategies\Strategy;
+use Knuckles\Scribe\ScribeServiceProvider;
 use Knuckles\Scribe\Tests\Fixtures\TestController;
 use Knuckles\Scribe\Tools\DocumentationConfig;
-use ReflectionClass;
-use ReflectionMethod;
 
 class GeneratorPluginSystemTestCase extends LaravelGeneratorTest
 {
@@ -167,6 +165,7 @@ public function dataResources()
     }
 }
 
+
 class EmptyStrategy1 extends Strategy
 {
     public static $called = [];