Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthrough부스 업데이트 작업에 회원 ID 기반 인증/인가 로직을 추가하고, 관리자 API와 공개 API 엔드포인트를 분리했습니다. 커맨드 서비스에 역할 검증 메서드를 도입하고, 컨트롤러의 메서드 시그니처를 업데이트하여 권한 확인을 강화했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AdminBoothAPI as AdminBoothApiController
participant BoothCmdService as BoothCommandService
participant MemberRepo as MemberRepository
participant BoothRepo as BoothRepository
Client->>AdminBoothAPI: PATCH /admin/booths/{id}<br/>(memberId, boothId, request)
activate AdminBoothAPI
AdminBoothAPI->>BoothCmdService: updateBooth(boothId, request, memberId)
activate BoothCmdService
BoothCmdService->>BoothRepo: findById(boothId)
activate BoothRepo
BoothRepo-->>BoothCmdService: Booth
deactivate BoothRepo
BoothCmdService->>BoothCmdService: validateRole(booth, memberId)
activate BoothCmdService
BoothCmdService->>MemberRepo: findById(memberId)
activate MemberRepo
MemberRepo-->>BoothCmdService: Member
deactivate MemberRepo
alt isAdmin or isOwner
BoothCmdService->>BoothCmdService: validation passed
else not authorized
BoothCmdService-->>BoothCmdService: throw ACCESS_DENIED
end
deactivate BoothCmdService
BoothCmdService->>BoothRepo: save(updatedBooth)
activate BoothRepo
BoothRepo-->>BoothCmdService: Booth
deactivate BoothRepo
BoothCmdService-->>AdminBoothAPI: BoothInfoResponseDto
deactivate BoothCmdService
AdminBoothAPI-->>Client: 200 OK
deactivate AdminBoothAPI
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
Summary by CodeRabbit
릴리스 노트
보안 개선
API 변경