Drop support for unmaintained Symfony versions #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see how complex adding Symfony 8 support would be and noticed that we require
"symfony/security-guard": "^5.4"which makes it hard to fully require Symfony 8 packages.I'm proposing to drop support for unmaintained Symfony versions first. This will make it easier to add support for Symfony 8.
Note: this means removing the abstract
SocialAuthenticatorclass. It cannot possibly work with Symfony > 5.4. I would not consider this a BC break because people on Symfony 5.4 will not get a new minor update anyway until they have to move to Symfony 6.4+ which means they need to change their authentication config anyway first.WDYT?