Skip to content

Conversation

@dmaicher
Copy link
Contributor

I wanted to see how complex adding Symfony 8 support would be and noticed that we require "symfony/security-guard": "^5.4" which makes it hard to fully require Symfony 8 packages.

I'm proposing to drop support for unmaintained Symfony versions first. This will make it easier to add support for Symfony 8.

Note: this means removing the abstract SocialAuthenticator class. It cannot possibly work with Symfony > 5.4. I would not consider this a BC break because people on Symfony 5.4 will not get a new minor update anyway until they have to move to Symfony 6.4+ which means they need to change their authentication config anyway first.

WDYT?

@dmaicher dmaicher force-pushed the drop_old_sf branch 2 times, most recently from 4cf1a38 to 308f234 Compare October 19, 2025 12:32
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sf 5.4 is LTS and still supports security fixes, so I would usually keep maintaining it unless it complicates moving forward too much like in this case. So I agree to drop that, we still have 6.4 LTS, should be good enough IMO

@bocharsky-bw
Copy link
Member

Thank you!

@bocharsky-bw bocharsky-bw merged commit 822916a into knpuniversity:main Nov 5, 2025
10 checks passed
@dmaicher dmaicher deleted the drop_old_sf branch November 5, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants