Skip to content

Fix test errors on main #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalilsn merged 2 commits into from
May 6, 2025
Merged

Fix test errors on main #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71acade
Use separate page for invite tests
kalilsn May 6, 2025
8bfcf47
Wait for confirmation after removing member
kalilsn May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/playwright/fixtures/member-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,6 @@ export class MembersPage {
await this.page.getByRole("button", { name: "Open menu", exact: true }).click();
await this.page.getByRole("button", { name: "Remove member", exact: true }).click();
await this.page.getByRole("button", { name: "Remove", exact: true }).click();
await this.page.getByText("Member successfully removed", { exact: true }).waitFor();
}
}
4 changes: 2 additions & 2 deletions core/playwright/invites.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ test.describe("invite reject flow", () => {
});

test.describe("different form/invite types", () => {
test("user can accept invite with pub level form", async () => {
test("user can accept invite with pub level form", async ({ page }) => {
await test.step("user can access invite with pub level form", async () => {
const invite = community.invites.pubLevelFormInvite;
const redirectTo = `/c/${community.community.slug}/public/forms/${community.forms.CommunityForm.slug}/fill?pubId=${pub1Id}`;
Expand Down Expand Up @@ -797,7 +797,7 @@ test.describe("different form/invite types", () => {
});

test.describe("different roles in invites", () => {
test("user can accept invite with admin role", async () => {
test("user can accept invite with admin role", async ({ page }) => {
await test.step("user can access invite with admin role", async () => {
const invite = community.invites.adminRoleInvite;
const redirectTo = `/c/${community.community.slug}/public/forms/${community.forms.Evaluation.slug}/fill`;
Expand Down
Loading