Skip to content

Home work #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Home work #3

wants to merge 2 commits into from

Conversation

shirmenzely
Copy link

No description provided.

AviadP
AviadP suggested changes Nov 28, 2019
View reviewed changes
igoihman
igoihman reviewed Nov 30, 2019
View reviewed changes
Copy link

@igoihman igoihman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks OK, please update the spaces according to the style guide

Challenge.py

word_count = Counter(contents)
print(word_count.most_common(1))
countDict={}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please read python style guide about spaces https://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@igoihman igoihman igoihman left review comments

@AviadP AviadP AviadP requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shirmenzely @AviadP @igoihman