Noam ossia's challenge HW #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviadP
suggested changes
Dec 1, 2019
|
|
||
| with open('sample.txt', 'r') as file: | ||
| data = file.read().replace('\n', '') | ||
| print("The content of the file is:\n\n" + data) |
There was a problem hiding this comment.
plz use f' string instead,
also, this output is not needed
| print("The content of the file is:\n\n" + data) | ||
|
|
||
|
|
||
| import re |
There was a problem hiding this comment.
all imports should be at the head of the file
| words = re.sub("[^\w]", " ", data).split() | ||
|
|
||
| for word in words: | ||
| from collections import Counter |
There was a problem hiding this comment.
Never use import within a loop
| from collections import Counter | ||
| word_counts = Counter(words) | ||
|
|
||
| MOword = word_counts.most_common(1)[0][0] |
There was a problem hiding this comment.
you should not use this module to solve the challenge. your should write your own algorithm
| MOword = word_counts.most_common(1)[0][0] | ||
| MOtimes = word_counts.most_common(1)[0][1] | ||
|
|
||
| print("\nThe most occuring word is {} and it occurs {} times".format(MOword,MOtimes)) |
There was a problem hiding this comment.
using f' string is best practice for python3, plz use this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.