This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Repository navigation
refactor: pipeline improvements and migrate NAPI tests to Bun - #172
Merged
Merged
Conversation
- Remove ExpressiveCode dual processing from blocksToJsx (pipeline-only now) - Extract ShikiManager class for consolidated Shiki lifecycle - Decouple blocksToJsx from Registry via local BlocksRegistry interface - Remove redundant normalize-steps/filetree TS transforms (handled in Rust) - Migrate 6 NAPI test files from AVA (.js) to Bun (.ts) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocksToJsx— code blocks always render as HTML<pre><code>, EC rewriting happens in pipeline onlyShikiManagerclass for consolidated Shiki lifecycle management (replaces scatteredgetShiki/shikiReadycalls)blocksToJsxfrommarkflow/registryvia localBlocksRegistryinterfacenormalize-steps.tsandnormalize-filetree.tsTS transforms (now handled in Rust codegen).js) to Bun (.ts), removing AVA dependencyTest plan
🤖 Generated with Claude Code