Skip to content

Conversation

@bernd-wiswedel
Copy link
Member

UIEXT-3076 (WebUI-Migration Send to Power BI)

Copilot AI review requested due to automatic review settings December 23, 2025 11:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements WebUI migration for the Send to Power BI node, replacing the legacy dialog implementation with the modern WebUI framework based on the DefaultNodeDialog pattern. The changes include new parameter classes, custom persistors for backward compatibility with existing settings, and comprehensive snapshot testing.

Key changes:

  • Migrated dialog configuration from legacy Java Swing to WebUI declarative parameters
  • Implemented custom persistors to maintain backward compatibility with existing settings format
  • Added snapshot testing for UI schema validation

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
SendToPowerBINodeFactory2.java Updated factory to implement NodeDialogFactory and use DefaultNodeDialog instead of legacy dialog
SendToPowerBINodeFactory2Parameters.java New WebUI parameters class defining all dialog fields, choices providers, and state management
SendToPowerBINodeSettings2.java Changed visibility of configuration keys from private to package-private for persistor access
TableNamesArrayPersistor.java Custom persistor for table names array maintaining backward compatibility with dual-array storage format
TableNameFieldPersistors.java Element field persistors for individual table name fields handling create/select mode logic
RelationshipsArrayPersistor.java Custom persistor for relationships array transforming between old and new formats
RelationshipFieldPersistors.java Element field persistors for relationship fields with cross-filter behavior serialization
SendToPowerBINodeFactory2ParametersTest.java Snapshot test class for validating parameter schema
SendToPowerBINodeFactory2ParametersTest.snap Generated snapshot file containing expected schema and UI configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from 559eb1f to 9ad7272 Compare December 23, 2025 13:28
Copilot AI review requested due to automatic review settings December 23, 2025 22:26
@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from 9ad7272 to 0fe02cf Compare December 23, 2025 22:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from 0fe02cf to 68c1254 Compare December 23, 2025 22:38
Copilot AI review requested due to automatic review settings December 24, 2025 09:48
@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from 68c1254 to 3832195 Compare December 24, 2025 09:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from 3832195 to 035bd3a Compare December 24, 2025 10:25
@knime knime deleted a comment from Copilot AI Dec 24, 2025
@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from 035bd3a to bae6f6a Compare December 24, 2025 11:35
Copilot AI review requested due to automatic review settings December 24, 2025 11:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernd-wiswedel bernd-wiswedel force-pushed the enh/UIEXT-3076-webui-migration-send-to-power-bi branch from bae6f6a to 85710ab Compare December 24, 2025 11:45
@bernd-wiswedel bernd-wiswedel marked this pull request as ready for review December 24, 2025 11:49
@bernd-wiswedel bernd-wiswedel requested a review from a team as a code owner December 24, 2025 11:49
Copilot AI review requested due to automatic review settings December 24, 2025 11:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernd-wiswedel
Copy link
Member Author

(There are failing tests, which are unrelated to this change... and discussed separately)

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.3% Coverage on New Code (required ≥ 85%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants