-
Notifications
You must be signed in to change notification settings - Fork 0
UIEXT-3076: test case added #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
UIEXT-3076: test case added #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements WebUI migration for the Send to Power BI node, replacing the legacy dialog implementation with the modern WebUI framework based on the DefaultNodeDialog pattern. The changes include new parameter classes, custom persistors for backward compatibility with existing settings, and comprehensive snapshot testing.
Key changes:
- Migrated dialog configuration from legacy Java Swing to WebUI declarative parameters
- Implemented custom persistors to maintain backward compatibility with existing settings format
- Added snapshot testing for UI schema validation
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| SendToPowerBINodeFactory2.java | Updated factory to implement NodeDialogFactory and use DefaultNodeDialog instead of legacy dialog |
| SendToPowerBINodeFactory2Parameters.java | New WebUI parameters class defining all dialog fields, choices providers, and state management |
| SendToPowerBINodeSettings2.java | Changed visibility of configuration keys from private to package-private for persistor access |
| TableNamesArrayPersistor.java | Custom persistor for table names array maintaining backward compatibility with dual-array storage format |
| TableNameFieldPersistors.java | Element field persistors for individual table name fields handling create/select mode logic |
| RelationshipsArrayPersistor.java | Custom persistor for relationships array transforming between old and new formats |
| RelationshipFieldPersistors.java | Element field persistors for relationship fields with cross-filter behavior serialization |
| SendToPowerBINodeFactory2ParametersTest.java | Snapshot test class for validating parameter schema |
| SendToPowerBINodeFactory2ParametersTest.snap | Generated snapshot file containing expected schema and UI configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.knime.ext.powerbi/src/org/knime/ext/powerbi/base/nodes/send2/TableNamesArrayPersistor.java
Outdated
Show resolved
Hide resolved
....powerbi/src/org/knime/ext/powerbi/base/nodes/send2/SendToPowerBINodeFactory2Parameters.java
Outdated
Show resolved
Hide resolved
....powerbi/src/org/knime/ext/powerbi/base/nodes/send2/SendToPowerBINodeFactory2Parameters.java
Outdated
Show resolved
Hide resolved
....powerbi/src/org/knime/ext/powerbi/base/nodes/send2/SendToPowerBINodeFactory2Parameters.java
Outdated
Show resolved
Hide resolved
559eb1f to
9ad7272
Compare
9ad7272 to
0fe02cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ests/src/org/knime/ext/powerbi/base/nodes/send2/SendToPowerBINodeFactory2ParametersTest.java
Outdated
Show resolved
Hide resolved
...nime.ext.powerbi/src/org/knime/ext/powerbi/base/nodes/send2/SendToPowerBINodeParameters.java
Outdated
Show resolved
Hide resolved
0fe02cf to
68c1254
Compare
68c1254 to
3832195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3832195 to
035bd3a
Compare
035bd3a to
bae6f6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
UIEXT-3076 (WebUI-Migration Send to Power BI)
bae6f6a to
85710ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
(There are failing tests, which are unrelated to this change... and discussed separately) |
|


UIEXT-3076 (WebUI-Migration Send to Power BI)