Skip to content

NXT-4224: WIP: New event type 'WORKFLOW_CHANGED' #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xnhp wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

NXT-4224: WIP: New event type 'WORKFLOW_CHANGED' #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f613ca
NXT-4224: WIP: New event type 'WORKFLOW_CHANGED'
kaifranze Nov 26, 2025
34eb54a
Attach & dispose syncer instance cleanly --
xnhp Dec 22, 2025
c7efd6d
`since` tags
xnhp Dec 22, 2025
0943003
Add unit tests for WorkflowResourceCache
xnhp Dec 23, 2025
d7a34c8
formatting
xnhp Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions org.knime.core/src/eclipse/org/knime/core/node/workflow/WorkflowEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ public enum Type {
/** Workflow is marked as clean (not dirty)
* @since 4.6 */
WORKFLOW_CLEAN,
/**
* The workflow has changed
*
* @since 5.10
*/
WORKFLOW_CHANGED,
/**
* Metadata of the currently open workflow (e.g. project or component) has changed
*
Expand Down
5 changes: 3 additions & 2 deletions org.knime.core/src/eclipse/org/knime/core/node/workflow/WorkflowManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9958,11 +9958,12 @@ void unsetDirty() {
/** {@inheritDoc} */
@Override
public void setDirty() {
boolean sendEvent = !isDirty();
boolean sendWorkflowDirtyEvent = !isDirty();
super.setDirty();
if (sendEvent) {
if (sendWorkflowDirtyEvent) {
notifyWorkflowListeners(new WorkflowEvent(WorkflowEvent.Type.WORKFLOW_DIRTY, getID(), null, null));
}
notifyWorkflowListeners(new WorkflowEvent(WorkflowEvent.Type.WORKFLOW_CHANGED, getID(), null, null));
Comment on lines 9965 to +9967
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WORKFLOW_CHANGED event is fired unconditionally on every setDirty() call, even when the workflow is already dirty. This could result in redundant event notifications for listeners. Consider firing this event only when sendWorkflowDirtyEvent is true, or document why unconditional firing is necessary for the browser sync functionality.

Suggested change
}
notifyWorkflowListeners(new WorkflowEvent(WorkflowEvent.Type.WORKFLOW_CHANGED, getID(), null, null));
notifyWorkflowListeners(new WorkflowEvent(WorkflowEvent.Type.WORKFLOW_CHANGED, getID(), null, null));
}

Copilot uses AI. Check for mistakes.
}

//////////////////////////////////////
Expand Down