-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add array of user agents for health check in drainer #2331
Conversation
e46d738
to
859de8c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2331 +/- ##
==========================================
+ Coverage 64.49% 64.56% +0.07%
==========================================
Files 226 226
Lines 9663 9668 +5
==========================================
+ Hits 6232 6242 +10
+ Misses 3155 3152 -3
+ Partials 276 274 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor stuff
1a59a1b
to
f4b670e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some bike shedding on the variable name & casing
note since the pkg cut had occurred this change won't be picked up till after the 1.0 release
f4b670e
to
75d42d4
Compare
no urgency since its mostly cleanup, will hold the serving PR until this is released |
75d42d4
to
2e684b4
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind enhancement
Fixes #
Release Note