Repository navigation
Only strip the config- prefix from ConfigMap names that have it - #2371
arpitjain099 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arpitjain099 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @arpitjain099! It looks like this is your first PR to knative/operator 🎉 |
|
Hi @arpitjain099. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change was written with the assistance of generative AI. I have reviewed and understand every change in it. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
7376b55 to
ec99af9
Compare
ConfigMapTransform looks a ConfigMap up by its full name, then again with the
config-prefix removed. The second lookup slices seven bytes off without checking the prefix is there, so a ConfigMap namedkafkapanics the reconciler withslice bounds out of range [7:5], andkourier-bootstrapgets looked up as-bootstrap. The bundled manifests are safe (38 names, none shorter than seven) and the line has been there since 2020, butspec.manifestsandspec.additionalManifeststake arbitrary URLs whose contents run through the same transformer.strings.CutPrefixleaves short and unprefixed names alone. Two cases added to the existing table./kind bug
Release Note
This change was written with the assistance of generative AI. I have reviewed and understand every change in it.