Skip to content

Only strip the config- prefix from ConfigMap names that have it - #2371

Open
arpitjain099 wants to merge 1 commit into
knative:mainfrom
arpitjain099:fix/configmap-prefix-slice
Open

arpitjain099 wants to merge 1 commit into
knative:mainfrom
arpitjain099:fix/configmap-prefix-slice

Conversation

@arpitjain099

@arpitjain099 arpitjain099 commented Nov 3, 2026 •

Copy link
Copy Markdown

ConfigMapTransform looks a ConfigMap up by its full name, then again with the config- prefix removed. The second lookup slices seven bytes off without checking the prefix is there, so a ConfigMap named kafka panics the reconciler with slice bounds out of range [7:5], and kourier-bootstrap gets looked up as -bootstrap. The bundled manifests are safe (38 names, none shorter than seven) and the line has been there since 2020, but spec.manifests and spec.additionalManifests take arbitrary URLs whose contents run through the same transformer.

strings.CutPrefix leaves short and unprefixed names alone. Two cases added to the existing table.

/kind bug

Release Note

Fix a panic in the KnativeServing and KnativeEventing reconcilers when a manifest contains a ConfigMap whose name is shorter than "config-".

This change was written with the assistance of generative AI. I have reviewed and understand every change in it.

@knative-prow knative-prow Bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 3, 2026
@knative-prow
knative-prow Bot requested review from aliok and matzew November 3, 2026 14:55
@knative-prow

knative-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arpitjain099
Once this PR has been reviewed and has the lgtm label, please assign evankanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow

knative-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown

Welcome @arpitjain099! It looks like this is your first PR to knative/operator 🎉

@knative-prow knative-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2026
@knative-prow

knative-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown

Hi @arpitjain099. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This change was written with the assistance of generative AI. I have
reviewed and understand every change in it.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@arpitjain099
arpitjain099 force-pushed the fix/configmap-prefix-slice branch from 7376b55 to ec99af9 Compare November 12, 2026 03:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant