Ignore no match errors on deleting obsolete resources #1739
Conversation
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/S
|
/cherry-pick release-1.13 |
|
/cherry-pick release-1.12 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.11 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
- Coverage 63.60% 63.54% -0.06%
==========================================
Files 53 53
Lines 2580 2584 +4
==========================================
+ Hits 1641 1642 +1
- Misses 825 827 +2
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. |
pierDipi
force-pushed
the
ignore-no-match-errors-on-delete-obsolete-resources
branch
2 times, most recently
from
a2efedb to
82a5a26
Compare
Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
force-pushed
the
ignore-no-match-errors-on-delete-obsolete-resources
branch
from
82a5a26 to
1345fba
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pierDipi: new pull request created: #1740 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierDipi: new pull request created: #1741 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierDipi: new pull request created: #1742 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.11 |
|
@houshengbo: new pull request created: #1749 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pierDipi
deleted the
ignore-no-match-errors-on-delete-obsolete-resources
branch
Maybe Fixes #1737
with eventing TLS, there are optional resources, only applied when a feature flag is enabled, so we need to ignore No match kind errors.