Do not remove the resources if status.Manifests is empty #1661
Conversation
knative-prow
bot
added
the
size/XS
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@houshengbo: 0 warnings.
In response to this:
Fixes #1652
Proposed Changes
- Do not remove the resources if status.Manifests is empty.
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 41 41
Lines 1857 1857
=======================================
Hits 1474 1474
Misses 279 279
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
/test eventing-upgrade-tests |
1 similar comment
|
/test eventing-upgrade-tests |
|
/lgtm |
|
/cherry-pick release-1.12 |
|
@houshengbo: new pull request created: #1664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.12 |
|
@houshengbo: new pull request created: #1665 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1652
Proposed Changes
Release Note