Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding banner for KubeConNA 23 #5740

Closed
wants to merge 1 commit into from
Closed

Adding banner for KubeConNA 23 #5740

wants to merge 1 commit into from

Conversation

nainaz
Copy link
Contributor

@nainaz nainaz commented Oct 27, 2023

Adding banner on knative site for KubeConNA 23

Proposed Changes

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 14c02c4
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/653be42766caf000087adba9
😎 Deploy Preview https://deploy-preview-5740--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from nak3 and pmbanugo October 27, 2023 16:24
@knative-prow
Copy link

knative-prow bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nainaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@nainaz nainaz requested review from csantanapr and lance and removed request for nak3 and pmbanugo October 27, 2023 16:24
@ReToCode
Copy link
Member

@nainaz this does not seem to look right to me:

image

Are the colors like this by intention?

@lance
Copy link
Member

lance commented Oct 30, 2023

@nainaz this does not seem to look right to me:

image

Are the colors like this by intention?

@nainaz if you change the background color value on line 161 to FFE6FB you can remove the added background-color directive here. That should fix the color issue.

@ReToCode
Copy link
Member

Closing this as kubecon NA has happened :)

@ReToCode ReToCode closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants