Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PingSource schedule seconds support documented #5737

Merged
merged 1 commit into from
Oct 26, 2023
Merged

PingSource schedule seconds support documented #5737

merged 1 commit into from
Oct 26, 2023

Conversation

SiBell
Copy link
Contributor

@SiBell SiBell commented Oct 26, 2023

PingSource docs updated to align with the code changes made in this PR: knative/eventing#7394

Proposed Changes

  • Documents how a PingSource's schedule now supports both the standard and Quartz Scheduler formats.

@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bc7f556
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/653a743a1e21fa00083545e4
😎 Deploy Preview https://deploy-preview-5737--knative.netlify.app/docs/eventing/sources/ping-source
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from pierDipi and ReToCode October 26, 2023 14:14
@knative-prow
Copy link

knative-prow bot commented Oct 26, 2023

Welcome @SiBell! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2023
@SiBell SiBell mentioned this pull request Oct 26, 2023
Merged
5 tasks
pierDipi
pierDipi approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 26, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, SiBell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@pierDipi
Copy link
Member

Thank you!

@knative-prow knative-prow bot merged commit 1ad1fe5 into knative:main Oct 26, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiBell @pierDipi