-
Notifications
You must be signed in to change notification settings - Fork 67
Create presubmit and end-to-end test infrastructure #25
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrcunha Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,8 @@ | |||
# The OWNERS file is used by prow to automatically merge approved PRs. | |||
|
|||
approvers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add me and mattmoor as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You and Matt are already owners because you're in the top level OWNERS file. Adding you here is unnecessary redundancy.
|
||
This directory contains tests and testing docs. | ||
|
||
* [Unit tests](#running-unit-tests) currently reside in the codebase alongside the code they test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it ever makes sense to run unit tests, to be honest. The intention of this repo is to be a catalog of reusable templates, and not to include any actual code.
Maybe someday we'll host the source for certain "official" builder images here too, and those might have unit tests? But for the foreseeable future, I don't expect us to have any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the wording is not the best here, since we won't have real code. But I can see "template validation" as unit tests, for example, and would love to see them here. It would run quickly and guard the templates against breakage. WDYT?
spec: | ||
source: | ||
git: | ||
url: https://github.com/my-user/my-repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention that this is a real repo containing buildpack-buildable source, and we'll watch the build to complete successfully? That seems like something we might just want to move into the build
repo, where we already have testing infrastructure for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, please note that without presubmit tests we can't have test jobs and thus can't have Prow to automatically merge PRs. |
/assign @imjasonh |
Partially addresses #16.
Notes:
run_buildpack_test()
is the only end-to-end test, and it doesn't actually check results (see Write end-to-end tests #24).