Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop performance tests #1372

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Apr 5, 2024

mako was a Google tool but it's no longer hosted and maintained so figure we can remove it for now

Part of knative/pkg#2820

@knative-prow knative-prow bot requested review from ikavgo and mkuratczyk April 5, 2024 17:16
Copy link

knative-prow bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2024
@ikavgo
Copy link
Contributor

ikavgo commented Apr 5, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@knative-prow knative-prow bot merged commit 4001bb8 into knative-extensions:main Apr 5, 2024
16 checks passed
@evankanderson
Copy link
Contributor

Sorry, just catching this now, but I don't think this was using mako at all? It looks like it was using gnuplot and some manual steps.

It would be nice to bring these back in a cross-Eventing way in some form, rather than having them buried in the rabbitmq implementation, but I wanted to make sure that I understood whether these were using Mako at all or not.

@gabo1208
Copy link
Contributor

We were using mako as a sidecar to knative perf test images, so maybe we didn't need mako at all, or just for some aggregation.

Should be not that hard to reuse the same images and aggregate, and just automating something like this results script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants