Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #12

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

siddiiqui7aslam
Copy link

These files are of the flutter app.

These files are of the flutter app.
Copy link
Contributor

@msripooja msripooja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving the PR, because the code is not following any project structure and security practices are not followed. Please check my review comments and do the changes accordingly.

main.dart Outdated
@@ -0,0 +1,163 @@
import 'package:flutter/material.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is no flutter project structure followed? I just see dart files and py files all in same folder. Use a proper project template.

noti.py Outdated
import googleapiclient.discovery

# Replace with your FCM server key
FCM_SERVER_KEY = "AIzaSyAtZw82wLJBShSjjsh2fEDJ"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API keys, server keys should be hidden or masked. Use a .env file and keep it within your team don't push to git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants