fix: make CreateEmbeddedPipPackagesForKnownPlatforms
work with windows paths
#50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19
files.json
(the file generated bydoWriteFilesList()
) stores platform-native paths to python packages. On Windows, the stored paths would be separated by backslashes, e.g.PIL\\BdfFontFile.py
.The stored paths are used directly by fs.ReadFile.
fs.ReadFile
is unconventional in that the paths MUST BE forward slashed regardless of the OS its ran on. From the io/fs docs:This PR converts the backslashes in the path to forward slashes right before calling
fs.ReadFile
. It does not change how the paths infiles.json
are stored.