ci(leak-detect): bump reusable to skip bot-authored PRs#51
Conversation
Picks up klodr/.github#39 (`33ff8e51`) — skips the leak-detect scan on any `[bot]` author so Dependabot bumps + release-please PRs no longer require a manual ruleset bypass to merge. Human PRs unchanged.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe ChangesWorkflow Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 3 3
Lines 81 81
Branches 21 21
=======================================
Hits 79 79
Misses 2 2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 104d8248a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # post-merge by the maintainer-side push trigger on main. | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: klodr/.github/.github/workflows/reusable-leak-detect.yml@7987f59050ff9ee614d21b603e4ba87ace27f7d9 | ||
| uses: klodr/.github/.github/workflows/reusable-leak-detect.yml@33ff8e518ecb7a799f114dc83ba06c9f0d660845 |
There was a problem hiding this comment.
Check the PR author instead of the trigger actor
This pins the caller to reusable workflow 33ff8e5, whose new skip guard tests github.actor rather than the PR author. This workflow also runs on pull_request edited and reopened events, so when a maintainer edits or reopens a Dependabot / release-please PR, the triggering actor is the human, the bot PR is not skipped, and it can still enter the private-key token step and fail—the case this bump is meant to unblock. Please point at a reusable ref that checks github.event.pull_request.user.login (or otherwise keys the skip off the PR author).
Useful? React with 👍 / 👎.
Picks up klodr/.github#39 (
33ff8e51) — leak-detect scan now skips whenendsWith(github.actor, '[bot]'), so Dependabot bumps andklodr-release-please[bot]PRs merge without needing a manual ruleset bypass. Human PRs unchanged.