- 
                Notifications
    You must be signed in to change notification settings 
- Fork 50
fix(deps): replace dependency eslint-plugin-node with eslint-plugin-n ^14.0.0 #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| Important Review skippedBot user detected. To trigger a single review, invoke the  You can disable this status message by setting the  WalkthroughThe ESLint configuration has been updated by removing the  Changes
 Poem
 Comment  | 
| ❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →
 | 
| ✅ Deploy Preview for kleros-v2-neo ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| ✅ Deploy Preview for kleros-v2-testnet ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
f14dcda    to
    433dcb8      
    Compare
  
    0546eb2    to
    a1cd487      
    Compare
  
    824fc17    to
    e7a92f0      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
eslint-config/package.json (1)
14-14: Ensure proper configuration ofeslint-plugin-nin ESLint configuration files.The replacement of
eslint-plugin-nodewitheslint-plugin-nversion^14.0.0is present ineslint-config/package.jsonandyarn.lock. However, there is no evidence ofeslint-plugin-nbeing configured in any ESLint configuration files. Please verify and update the ESLint configuration files to includeeslint-plugin-n.
eslint-config/package.json
yarn.lockAnalysis chain
LGTM! Verify the installation and configuration of
eslint-plugin-n.The replacement of
eslint-plugin-nodewitheslint-plugin-nversion^14.0.0is approved.Ensure that the new plugin is correctly installed and configured to maintain linting capabilities.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the installation and configuration of `eslint-plugin-n`. # Test: Check if `eslint-plugin-n` is installed. Expect: The package should be listed. npm list eslint-plugin-n # Test: Check if `.eslintrc.js` contains the configuration for `eslint-plugin-n`. Expect: The configuration should be present. rg --type js 'eslint-plugin-n' .eslintrc.jsLength of output: 194
Script:
#!/bin/bash # Description: Search for ESLint configuration files and check for `eslint-plugin-n` configuration. # Find all potential ESLint configuration files in the repository. fd -e js -e json -e yaml -e yml -e cjs -e mjs -e ts -e coffee --regex 'eslint' # Check if any of these files contain the configuration for `eslint-plugin-n`. fd -e js -e json -e yaml -e yml -e cjs -e mjs -e ts -e coffee --regex 'eslint' --exec rg 'eslint-plugin-n' {}Length of output: 188
Script:
#!/bin/bash # Description: Search all files in the repository for `eslint-plugin-n` configuration. # Check if any files in the repository contain the configuration for `eslint-plugin-n`. rg 'eslint-plugin-n'Length of output: 262
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
- yarn.lockis excluded by- !**/yarn.lock,- !**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
6441627    to
    444d4c2      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
- yarn.lockis excluded by- !**/yarn.lock,- !**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- eslint-config/package.json
444d4c2    to
    f40ae42      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
- yarn.lockis excluded by- !**/yarn.lock,- !**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- eslint-config/package.json
f40ae42    to
    e3392d8      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
- yarn.lockis excluded by- !**/yarn.lock,- !**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- eslint-config/package.json
e3392d8    to
    2fffb97      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
- yarn.lockis excluded by- !**/yarn.lock,- !**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- eslint-config/package.json
2fffb97    to
    04a6b46      
    Compare
  
    6e27350    to
    21c2817      
    Compare
  
    7fcbdd1    to
    9f1ca5c      
    Compare
  
    0b03836    to
    949be22      
    Compare
  
    0a463aa    to
    3764b3a      
    Compare
  
    d8b2579    to
    74de3ce      
    Compare
  
    6acff93    to
    8c4669e      
    Compare
  
    b8c8009    to
    823bb48      
    Compare
  
    823bb48    to
    7d7b957      
    Compare
  
    | 
 | 



This PR contains the following updates:
^11.1.0->^14.0.0This is a special PR that replaces
eslint-plugin-nodewith the community suggested minimal stable replacement version.Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
PR-Codex overview
This PR focuses on updating the
eslintrelated packages and their configurations in theeslint-config/package.jsonandyarn.lockfiles. It replaceseslint-plugin-nodewitheslint-plugin-n, upgrades the version ofeslint-plugin-es, and addsis-core-module.Detailed summary
eslint-plugin-nodewitheslint-plugin-n(version updated from^11.1.0to^14.0.0).eslint-plugin-esversion from^3.0.0to^4.1.0.is-core-modulewith version^2.3.0.eslint-utilsversion from^2.0.0to^3.0.0.eslintpeer dependency from>=5.16.0to>=7.0.0.